Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate all sessions of a user on password change #1680

Open
jholdstock opened this issue Oct 7, 2022 · 0 comments · May be fixed by #1681
Open

Invalidate all sessions of a user on password change #1680

jholdstock opened this issue Oct 7, 2022 · 0 comments · May be fixed by #1681

Comments

@jholdstock
Copy link
Member

This was implemented previously in #647 but the functionality seems to have stopped working.

Sharing the report which came in from the bug bounty program:

While conducting my research I discovered that the application failed to invalidate the session after password change from profile settings. In this scenario changing the password doesn’t destroy the other sessions logged in with old passwords.

Steps to reproduce:

  • Register an account on https://proposals.decred.org

  • Login with the same account in Chrome and Firefox Simultaneously.

  • In Chrome Browser go to Profile https://proposals.decred.org/user/?tab=account and change the password.

  • Go to Firefox and Update any information, information will be updated *If the attacker login with Firefox and the user knows his password is stolen so even user changes their password, his account remains insecure and the attacker has full access to the victim's account.

If the attacker has a user password and logs in different places, As other sessions are not destroyed, the attacker will still be logged in to your account even after changing the password, cause his session is still active. A malicious actor can completely access your account till that session expires! So, your account remains insecure even after the change of the password.

@lukebp lukebp linked a pull request Oct 12, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant