Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the AssetImage component from the UI #2234

Open
LautaroPetaccio opened this issue Apr 24, 2024 · 4 comments
Open

Use the AssetImage component from the UI #2234

LautaroPetaccio opened this issue Apr 24, 2024 · 4 comments

Comments

@LautaroPetaccio
Copy link
Contributor

LautaroPetaccio commented Apr 24, 2024

This ticket is part of the Simplify the AssetImage component initiative which has as its objective the simplification of the AssetImage component, making it exportable to other projects.

To complete this task:

  • Remove the AssetImage component in the Marketplace and use it from the UI repository.
@LautaroPetaccio LautaroPetaccio changed the title Update the AssetImage component in the UI Update the AssetImage component with its Marketplace counterpart Apr 24, 2024
@LautaroPetaccio LautaroPetaccio changed the title Update the AssetImage component with its Marketplace counterpart Use the AssetImage component from the UI Apr 24, 2024
@Jagadeeshftw
Copy link

I want to work on this issue, can you please assign this to me?

@LautaroPetaccio
Copy link
Contributor Author

Hi @Jagadeeshftw , before starting this task, there's another task that needs to be completed, decentraland/ui#533.

@Jagadeeshftw
Copy link

Hi @LautaroPetaccio, Since the UI and marketplace repositories are on different Node.js versions, I’m encountering dependency conflicts when trying to move assertImage from the marketplace repository to the UI. Do you have any suggestions?

@LautaroPetaccio
Copy link
Contributor Author

Hi @Jagadeeshftw , what's causing this issue between the two versions?
Moving the AssetImage component from one repository to the other implies more than just copy pasting the code. We plan to migrate the UI logic into the UI repository, leaving the data consumption layer in the Marketplace repository, along some other refactors, like removing the WearablePreview from it. This issue kind of requires some context and the knowledge of the repositories. I would recommend you to start with issues under the good first issue category.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants