Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACL options #16

Open
stefangweichinger opened this issue Oct 22, 2017 · 13 comments
Open

ACL options #16

stefangweichinger opened this issue Oct 22, 2017 · 13 comments

Comments

@stefangweichinger
Copy link

how to get options deployed like in

https://wiki.samba.org/index.php/Setting_up_a_Share_Using_Windows_ACLs#Enable_Extended_ACL_Support_in_the_smb.conf_File

?
Do they have to be added to the role or may they get added within some specific (and existing) variable?

@drybjed
Copy link
Member

drybjed commented Oct 22, 2017

At the moment you could specify them in the samba__global_custom hash. This role needs to be rewrtitten to make things like these easier to do though. I guess it will be done at some point, but not just now - other things to do at the moment.

@stefangweichinger
Copy link
Author

Do I have to use a specific formatting for the options inside that hash? thanks.

@drybjed
Copy link
Member

drybjed commented Oct 22, 2017

You could try putting the option names with spaces in '' quotation marks.

@stefangweichinger
Copy link
Author

I see. Will test on a non-productive machine first ;-) (always a good idea).
Maybe I provide my example for the docs then?

@drybjed
Copy link
Member

drybjed commented Oct 22, 2017

Sure, however if you want to do a PR, do it against the new debops/debops repository. Keep in mind that the Samba role is in a subdirectory.

More info here: https://lists.debops.org/pipermail/debops-users/2017-October/000102.html

@stefangweichinger
Copy link
Author

Let me be lazy for now and paste my example in here. PR later, ok?

# host_vars file for specific machine

samba__global_custom:
  vfs_objects: 'acl_xattr'
  map_acl_inherit: 'yes'
  store_dos_attributes: 'yes'

# sgw: above vfs_objects setting needs additional vfs-modules pkg installed
samba__base_packages:
  - 'samba'
  - 'samba-common'
  - 'samba-common-bin'
  - 'samba-vfs-modules'

tested right now, generates working config on target machine.

@drybjed
Copy link
Member

drybjed commented Oct 22, 2017

Sure, sounds good.

@stefangweichinger
Copy link
Author

forked/cloned your new repo (great work, btw!) but can't find the sources for the docs in there. Did some finds and greps ... pls advise.

@drybjed
Copy link
Member

drybjed commented Oct 23, 2017

Currently the documentation is still in the role directories. The debops.samba role doesn't have the new documentation yet. I guess that we can add it later, when the documentation merge is done.

@stefangweichinger
Copy link
Author

So PR against this repo here instead?

@drybjed
Copy link
Member

drybjed commented Oct 23, 2017

No, if you want to do a PR, please do it against debops/debops now. I suppose that you can add a file like ansible/roles/debops.samba/docs/examples.rst with some example configuration, then it can be dealt with later.

The old role repositories will become read-only. I plan do write a script that will extract the roles from the monorepo and publish them so that they can still be accessed via Galaxy, in a somewhat simple form.

@stefangweichinger
Copy link
Author

OK, understood. I will do that asap.
Keep up the good work ;-)

@stefangweichinger
Copy link
Author

debops/debops#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants