Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Missing stream commands XINFO, XADD, XTRIM, XDEL, XRANGE, XREVRANGE, XLEN, XREAD, XGROUP, XREADGROUP. XACK, XCLAIM, XAUTOCLAIM, XPENDING #272

Open
zizzle6717 opened this issue Aug 18, 2021 · 4 comments

Comments

@zizzle6717
Copy link
Collaborator

I think the implementation of many of these methods would be fairly straightforward. I was able to easily extend RedisClient and add them myself, but the issue is using those methods with RedisClientPool which is not so simple. Adding these methods would make them available when using a pool.

I will gladly open a PR if there is no reason not to add these commands. Thank you!

@zizzle6717
Copy link
Collaborator Author

Others include BZPOPMIN, BZPOPMAX...

and for streams...

XINFO, XADD, XTRIM, XDEL, XRANGE, XREVRANGE, XLEN, XREAD, XGROUP, XREADGROUP. XACK, XCLAIM, XAUTOCLAIM, XPENDING https://redis.io/commands#stream

@zizzle6717
Copy link
Collaborator Author

Here is a PR to add the missing sorted set commands, #273

@zizzle6717 zizzle6717 changed the title Missing various methods such as ZPOPMIN, ZPOPMAX, and many more Update: Missing stream commands XINFO, XADD, XTRIM, XDEL, XRANGE, XREVRANGE, XLEN, XREAD, XGROUP, XREADGROUP. XACK, XCLAIM, XAUTOCLAIM, XPENDING Sep 1, 2021
@debasishg
Copy link
Owner

Hi @zizzle6717 - should we close this issue ? Does the PR handle all parts of the issue ?

@zizzle6717
Copy link
Collaborator Author

@debasishg I have updated the title, because the PR only added sorted set commands (ZPOPMIN, ZPOPMAX, ETC.)...We are still missing the stream commands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants