Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate fewer media queries #5

Open
dawaltconley opened this issue May 12, 2023 · 0 comments
Open

Generate fewer media queries #5

dawaltconley opened this issue May 12, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@dawaltconley
Copy link
Owner

Currently, the generateMediaQueries function outputs a media query for every device, regardless of whether that device reuses the same image as another. This can be optimized by removing media queries that don't affect the image selection.

It could also be optimized by bundling the media queries, as with postcss-sort-media-queries. This only affects CSS output though and wouldn't work with picture elements, which are currently unimplemented but would use the same function.

Generating fewer queries will actually make them harder to bundle, but it is probably worth doing both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant