You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TypeError: singleton can't be dumped
from /usr/local/bundle/gems/novel-0.3.0/lib/novel/repository_adapters/redis.rb:16:in `dump'
Reason
Unit is defined as singleton instance of Object, which means it can't be dumped by Marshal.dump which is used by Redis RepositoryAdapter here.
Potential solution
I think it can be avoided by introducing custom marshalling of Novel::Context but context serialiser location, on my opinion, should be in adapter. I'll try to resolve the issue and create PR for it.
The text was updated successfully, but these errors were encountered:
Hi there.
Issue
Noticed that saga with Redis adapter fails if step returns empty Success or Failure value. This is caused by next equality
Script to reproduce
Expected result:
Successful saga execution
Actual result:
Reason
Unit
is defined as singleton instance ofObject
, which means it can't be dumped byMarshal.dump
which is used by Redis RepositoryAdapter here.Potential solution
I think it can be avoided by introducing custom marshalling of
Novel::Context
but context serialiser location, on my opinion, should be in adapter. I'll try to resolve the issue and create PR for it.The text was updated successfully, but these errors were encountered: