Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "last" on Link header #123

Open
seidelmaycon opened this issue Mar 18, 2019 · 1 comment
Open

Missing "last" on Link header #123

seidelmaycon opened this issue Mar 18, 2019 · 1 comment

Comments

@seidelmaycon
Copy link

Hi folks, first of all, thanks for providing this awesome resource.

Recently I updated the api-pagination from 4.8.1 to 4.8.2 and some unit tests started to fail.

We were used to receiving first, last, prev and next on the Link header. But after the upgrade to the last version the last option disappeared from Link header.

Let me know if I am doing any confusion and/or am missing any optional configuration. Also, I could provide more information if it's necessary.

Thank you.

@davidcelis
Copy link
Owner

davidcelis commented Mar 18, 2019

Hmmm my guess is this is due to #107… Are you configuring api-pagination to not include the Total header? The main reason that people configure this is due to expensive queries for the sizes of large tables, which the rel="last" URL does as well, so merging #107 made sense to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants