Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve language server implementation (configuration handling) #555

Open
Shikachuu opened this issue Sep 23, 2024 · 0 comments
Open

Improve language server implementation (configuration handling) #555

Shikachuu opened this issue Sep 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Shikachuu
Copy link
Contributor

To further improve the language server protocol:

  • we should use the InitializationOptions to get the configuration from the client side (which should be parsed/validated in this case) and merge it in viper.
  • also we need to implement workspace/didChangeConfiguration which is used to update the running configuration in the server (this also should be parsed/validated) and merged with the running viper config.

With this options you would be able to dynamically reconfigure vacuum through the json rpc protocol from the client side.

If this should be a recommended way to configure vacuum is also an acceptable opinion, imho in that case this functionality should expose only a "configuration-file" option, to be able to use different configuration files like when you run vacuum as a cli app.

@daveshanley daveshanley added the enhancement New feature or request label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants