Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couldn't start client vacuum #538

Open
sk185050 opened this issue Sep 2, 2024 · 3 comments
Open

Couldn't start client vacuum #538

sk185050 opened this issue Sep 2, 2024 · 3 comments

Comments

@sk185050
Copy link

sk185050 commented Sep 2, 2024

[Error - 4:23:00 PM] Starting client failed
Error: spawn EINVAL
at ChildProcess.spawn (node:internal/child_process:421:11)
at Object.spawn (node:child_process:799:9)
at c:\Users<usename>.vscode\extensions\pb33f.vacuum-0.0.7\node_modules\vscode-languageclient\lib\node\main.js:383:40

@LasneF
Copy link

LasneF commented Sep 2, 2024

can you provide the version of vacuum and nodeJS used , it might be related to nodeJs installation
not sure if that is related ( https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2 )

so you may proceed an node ugrade , please share your result

@LasneF
Copy link

LasneF commented Sep 3, 2024

looks an issue in the way the vacuum is launched from vscode (and may be due to vscode update)
@daveshanley is the vscode extension opensource , but the correction looks simple

we just need to add a dedicated parameter to make it back available on windows
as mentionned in nodeJS doc

"
It is important to note that there has been a breaking change for Windows users who utilize child_process.spawn and child_process.spawnSync. Node.js will now error with EINVAL if a .bat or .cmd file is passed to child_process.spawn and child_process.spawnSync without the shell option set. If the input to spawn/spawnSync is sanitized, users can now pass { shell: true } as an option to prevent the occurrence of EINVALs errors."

@daveshanley
Copy link
Owner

mmm.. ok, will look into this asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants