Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating html-report from Vacuum report does not support custom rules #528

Open
LittleGreenYoda42 opened this issue Jul 25, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@LittleGreenYoda42
Copy link

When creating an html-report from a vacuum report, the html page only contains results for the default rules.

This is because when re-creating the nodes from the report data, the rule data is taken from the OpenAPIDefaultRuleSet and retrieved via the rule-id..

As custom rules are not contained in the default ruleset, the rule definition is nil.
This has the effect that the function for getting rules by category will exclude the results for custom rules by checking that the rule must not be nil.

I guess one option could be to put the ruleset used for creating the report into the report as well. Another one to let the user hand in the same ruleset again when creating the html-report and reading from the vacuum report file. (although that feels strange)

@daveshanley daveshanley added the bug Something isn't working label Jul 29, 2024
@daveshanley
Copy link
Owner

This is a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants