Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raindrop details with square brackets in not showing everything #64

Closed
davep opened this issue Jan 9, 2025 · 0 comments · Fixed by #65
Closed

Raindrop details with square brackets in not showing everything #64

davep opened this issue Jan 9, 2025 · 0 comments · Fixed by #65
Assignees
Labels
Bug Something isn't working TODO A thing I'm planning on doing

Comments

@davep
Copy link
Owner

davep commented Jan 9, 2025

I need to remember to escape anything that will be shown, as by default Textual will treat the content of a Label as Rich markup; the result being something like this:

Screenshot 2025-01-09 at 16 58 48

Note how the title and excerpt in the details panel are empty.

The usual method of handling this is to set markup=False on the Label but this seems to have been broken in Textual 0.86: Textualize/textual#5468

Update the details panel code so that it uses rich.markup.escape, as a workaround.

@davep davep added Bug Something isn't working TODO A thing I'm planning on doing labels Jan 9, 2025
@davep davep self-assigned this Jan 9, 2025
@davep davep changed the title Raindrop details with square brackets in now showing everything Raindrop details with square brackets in not showing everything Jan 9, 2025
davep added a commit that referenced this issue Jan 9, 2025
@davep davep closed this as completed in #65 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working TODO A thing I'm planning on doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant