Non-submitted applications are shown in the application overview

[Herkarl]

I noticed this while going through the application flow, where I just completed up to and including step 3, i.e never pressing the "Ansök!"-button on page 4. But in https://haj.metaspexet.se/applications, I am listed among the applicants.

I don't know how common it is that someone decides not to finish their application, but if it would happen I believe this would be quite bad.

I can see an argument for that this could be seen as a protection for people forgetting to finish their application. But I would say that that does not weight up, since this is un-intutitive behavior, and could be a data-integrity concern (data should not be visible unless it is very clear for the user that it is).

I realise there is some nuance here since we have a "draft-application" feature, which I think is very good and a point for usability. So I think the most important thing would be that the application is not visible in https://haj.metaspexet.se/applications if it is not explicitly submitted, in order to prevent sending emails for interviews etc. to these users.

[adriansalamon]

Fixed in #75, but the only issue here is that if a user submits an application, and then goes back and updates their groups, I am not sure how to handle this. I've now made it so that it updates the groups in the database, and sets the application as "pending", and added a warning message reminding users to submit the application in order to save it.

[Herkarl]

Nice!

I kinda feel like it would be fine to keep the application as submitted in that case, but if the warning is clear I think that is a reasonable solution. As long as the risk of us loosing any applications is negligible.

One solution I suppose would be to create a second pending application and then delete the old submitted application once the new one is submitted, but that might have a high chance of generating spaghetti code depending on how things are currently structured.

[adriansalamon]

I implemented what you suggested, and I agree that it seems like the best thing to do.