Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced validation and cleaning #20

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

CBROWN-ONS
Copy link
Collaborator

@CBROWN-ONS CBROWN-ONS commented Jul 2, 2024

Description

This issue merges some of the features from TP #195
This PR will allow for a pipelined approach while cleaning and validating a GTFS.

Fixes #4,
Fixes #5,
Fixes #6,
Fixes #7,
Fixes #10,
Fixes #11,
Fixes #22,
Fixes #23,

Motivation and Context

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Test configuration details:

  • OS: Windows 10
  • Python version: 3.9.13
  • Java version: N/A
  • Python management system: MiniConda

Advice for reviewer

Checklist:

  • My code follows the intended structure of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional comments

Copy link

codecov bot commented Jul 2, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@r-leyshon r-leyshon marked this pull request as draft July 2, 2024 13:33
@CBROWN-ONS CBROWN-ONS requested a review from r-leyshon July 3, 2024 09:29
@CBROWN-ONS CBROWN-ONS marked this pull request as ready for review July 3, 2024 09:29
@CBROWN-ONS
Copy link
Collaborator Author

@r-leyshon Any thoughts on the failing test here?

@r-leyshon
Copy link
Contributor

r-leyshon commented Jul 31, 2024

@CBROWN-ONS yeah I didn't get round to.sorting this. It should be simple enough. The failing test shouldn't exist any more in dev branch. I think k there's a bunch of changes in dev that should be merged to this branch and then everything will pass again hopefully.

Update - merging changes in dev removed the outdated test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants