Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI and routes for updating permissions for a collection of items #1008

Open
ml-evs opened this issue Nov 14, 2024 · 0 comments
Open

UI and routes for updating permissions for a collection of items #1008

ml-evs opened this issue Nov 14, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ml-evs
Copy link
Member

ml-evs commented Nov 14, 2024

Following (the hopefully imminent) #830, we also need a sensible way for updating permissions on collections of items (raised by @PeterKraus in concat-lab/datalab-deployment#5).

We can easily add the new component to a collection, and somehow this should add the creators selected to all items within the collection. This should then be extended such that any future item that gets added to that collection also gets the same permissions (handy when e.g., the same group of people are working on the same set of items in a given project).

I think we will need to be quite delicate with our current permissions model, so I might do the simple implementation of this feature but add it behind a feature flag so that @PeterKraus can give feedback from his group.

There is also an outstanding bug with collections where an admin can add an item into a collection that they do not have permissions over; the original owner of the sample then does not have permissions to edit that sample, since they end up trying to reset the collection data that they do not know about (see #842)! This is probably also quite an urgent fix before working on this feature, as well as a few other related issues #790

@ml-evs ml-evs added the enhancement New feature or request label Nov 14, 2024
@ml-evs ml-evs self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant