Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this plugin doesn't work for mysql database #8

Open
yohayg opened this issue Oct 10, 2018 · 4 comments
Open

this plugin doesn't work for mysql database #8

yohayg opened this issue Oct 10, 2018 · 4 comments

Comments

@yohayg
Copy link
Contributor

yohayg commented Oct 10, 2018

The mysql driver doesn't return the database name. I have a branch ready
@yohayg
Copy link
Contributor Author

yohayg commented Oct 10, 2018

please give me permission to open a new feature branch

@nitinmotgi
Copy link

Fork the repo into your account, make changes and then submit a PR.

@albertshau
Copy link
Collaborator

albertshau commented Oct 10, 2018 •
edited
Loading

I ran into the same issue and have a fix on #7, along with changes to support date/time types, though it also bumps the versions up to latest

@yohayg
Copy link
Contributor Author

yohayg commented Oct 16, 2018

Hi, The latest merge to develop branch fixed the mysql issue. However the co.cask.plugin.PipelineTest is failing due to: java.lang.IllegalArgumentException: Name 'PUBLIC.MULTI2-47fedc9d-c01b-4149-857e-71eb69b65199' must consist only of ASCII letters, numbers, _, or -.
I'll just submit the mysql test. I'll open a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nitinmotgi @yohayg @albertshau