Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Add TargetLinkUrl to MessageEvent #152

Open
zythra opened this issue Sep 22, 2017 · 4 comments
Open

Request: Add TargetLinkUrl to MessageEvent #152

zythra opened this issue Sep 22, 2017 · 4 comments

Comments

@zythra
Copy link
Contributor

zythra commented Sep 22, 2017

Can TargetLinkUrl be added to MessageEvent please? I've added it in a cloned repo, but the change is so small I don't know that it's worth creating a pull request for it. It was as simple as adding the property to MessageEvent and adding the mapping "TargetLinkUrl = result.target_link_url" in the ConvertResultsToAListOfMessageEvents() method in the MessageEvents class.

Thanks!

@Richard-West
Copy link

Create a Pull Request so this can be implemented

@zythra
Copy link
Contributor Author

zythra commented Oct 11, 2017

@Richard-West Funny you should mention this today as I was just thinking this morning I'd just go ahead and do it. Is this something you're after as well or were you just giving me a little push? ;)

@zythra
Copy link
Contributor Author

zythra commented Oct 11, 2017

Pull request submitted.

https://github.com/darrencauthon/csharp-sparkpost/pull/153

@Richard-West
Copy link

Richard-West commented Oct 11, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants