Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Substitute CV_NNLS_fit into code structure #44

Open
JoJas102 opened this issue Dec 19, 2023 · 1 comment
Open

Substitute CV_NNLS_fit into code structure #44

JoJas102 opened this issue Dec 19, 2023 · 1 comment
Labels
flavour Optional quality of life change with lower priority

Comments

@JoJas102
Copy link
Collaborator

JoJas102 commented Dec 19, 2023 •
edited
Loading

Substitute additional CV_NNLS_fit() with standard Model.NNLS.fit() already implemented
@JoJas102
Copy link
Collaborator Author

Problem of circular import with Model.py through model.NNLS.fit()

JoJas102 added a commit that referenced this issue Dec 19, 2023
@JoJas102
Continued reworking NNLS reg CV (#44)
df82526 
Implemented get_G and get_basis method into NNLSregCVParams;
Still need to pmplemetn correct fitting link and also check fitting input for correct dimensions (basis and signal handeled differently in CV_NNLS_fit method)
JoJas102 added a commit that referenced this issue Dec 21, 2023
@JoJas102
Integrate NNLS reg CV into code structure #44
4c7b26f
@JoJas102 JoJas102 added the flavour Optional quality of life change with lower priority label Mar 14, 2024
@JoJas102 JoJas102 changed the title Substitute additional CV_NNLS_fit() with standard Model.NNLS.fit() already implemented Substitute CV_NNLS_fit code structure Mar 14, 2024
@JoJas102 JoJas102 changed the title Substitute CV_NNLS_fit code structure Substitute CV_NNLS_fit into code structure Mar 14, 2024
@darksim33 darksim33 added this to the Release 1.0 milestone Mar 14, 2024
JoJas102 added a commit that referenced this issue Mar 14, 2024
@JoJas102
Removed TODO covering issue #44
cca32cd
@JoJas102 JoJas102 removed this from the Release 1.0 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flavour Optional quality of life change with lower priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoJas102 @darksim33