Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework fitting models #152

Open
darksim33 opened this issue Dec 5, 2024 · 0 comments · Fixed by #158
Open

rework fitting models #152

darksim33 opened this issue Dec 5, 2024 · 0 comments · Fixed by #158
Assignees
@darksim33
Labels
enhancement New feature or request fitting Fitting related
Milestone
Version 2.0

Comments

@darksim33
Copy link
Owner

Rework fitting models in the same way the pygpufit models are designed. Change "scale_image" and "n_components" to a single variable that defines the model. move wrapper and use fixed models as defaults with wrapper as option for advanced tinkering.
@darksim33 darksim33 added enhancement New feature or request fitting Fitting related labels Dec 5, 2024
@darksim33 darksim33 self-assigned this Dec 5, 2024
@darksim33 darksim33 added this to the Version 2.0 milestone Dec 11, 2024
@darksim33 darksim33 linked a pull request Dec 11, 2024 that will close this issue
152-rework-fitting-models #158
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darksim33 darksim33

Labels
enhancement New feature or request fitting Fitting related
Projects
None yet
Milestone
Version 2.0
Development

Successfully merging a pull request may close this issue.

152-rework-fitting-models darksim33/Pyneapple
1 participant
@darksim33