Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MS Edge is detected as Chrome #39

Closed
julkue opened this issue Oct 20, 2015 · 9 comments
Closed

MS Edge is detected as Chrome #39

julkue opened this issue Oct 20, 2015 · 9 comments

Comments

@julkue
Copy link
Collaborator

julkue commented Oct 20, 2015

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36 Edge/12.10240

@julkue julkue changed the title Will detect MS Edge as Chrome MS Edge is detected as Chrome Oct 20, 2015
@AdrianoCahete
Copy link
Collaborator

Fixed in PR #38

But only @darcyclarke can merge.

If you really need right now, you can use my fork then replace with original when this PR is merged.

@julkue
Copy link
Collaborator Author

julkue commented Oct 20, 2015

This is crap.. Look at his "Public contributions" (stats). We should fork the project somewhere else and contribute it with more authorized and active persons

@AdrianoCahete
Copy link
Collaborator

I don't know if he abandoned this project, but the lastest activity in this project is from May, 4 (with a file merge not-generated by npm). But if he really abandoned it, i can make my fork updated, 'cause we use it in my work.

@julkue
Copy link
Collaborator Author

julkue commented Oct 20, 2015

@darcyclarke Closed without any comment? Will you contribute and merge pull requests in this repo actively?

@AdrianoCahete
Copy link
Collaborator

He put you and me as Collaborator, so we can push new modifications and merge PR's, as some others permissions too.

@darcyclarke
Copy link
Owner

@julmot @AdrianoCahete I'm looking at this right now. Lots to be done. Also, I made you both collaborators so you can ensure things are progressing along and this repo doesn't become stale again. I appreciate both of your contributions and hard work! 👍

@julkue
Copy link
Collaborator Author

julkue commented Oct 20, 2015

@darcyclarke Thank you for this information. What would you think about moving the project to a separate organization to keep developing flexible?

@darcyclarke
Copy link
Owner

@julmot I'm not sure about a separate org. I can't see the need for other repos that would be relevant to this project; That's usually my predicate for creating a new organization. I think it's definitely important to make sure development doesn't fall off a cliff again but I think that comes down to having good collaborators on board (which I'm hoping you and @AdrianoCahete can be). If not, then there's a lot of pressure on a admin/creator whether or not there's an organization.

@julkue
Copy link
Collaborator Author

julkue commented Oct 20, 2015

@darcyclarke My philosophy is to have at least two repositories.

  1. One that will host all regexes. A simple frontend application (e.g. with AngularJS) will show the supported browsers/os based on the database in this repository. This would close Can provide a list for supported Operation System and Browser in README? #34
  2. The second will host the detect.js-library for clientside browser/os-detection based on the database repository (will be loaded with e.g. bower)
    This could be done with a separate organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants