Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-on-droid support #775

Open
brckd opened this issue Jan 15, 2025 · 4 comments · May be fixed by #778
Open

nix-on-droid support #775

brckd opened this issue Jan 15, 2025 · 4 comments · May be fixed by #778
Labels
feature A new feature or a feature request

Comments

@brckd
Copy link
Contributor

brckd commented Jan 15, 2025

nix-on-droid has terminal.colors and terminal.font options that could be set by Stylix, but the only nix-on-droid users I know of who would use this are @voronind-com and I. Would support for nix-on-droid be a appreciated feature? If so, I could attempt implementing it.

@voronind-com
Copy link

voronind-com commented Jan 16, 2025

Even I'd appreciate a proper module instead of what I have now. I guess more people would use it if it becomes straightforward?

@trueNAHO trueNAHO added the feature A new feature or a feature request label Jan 18, 2025
@trueNAHO
Copy link
Collaborator

nix-on-droid has terminal.colors and terminal.font options that could be set by Stylix, but the only nix-on-droid users I know of who would use this are @voronind-com and I. Would support for nix-on-droid be a appreciated feature? If so, I could attempt implementing it.

[...]

Even I'd appreciate a proper module instead of what I have now. I guess more people would use it if it becomes straightforward?

Yes, I think it would be neat to support this in Stylix. After all, we already support niche setups like Flatpak thanks to @brckd.

What would the implementation look like? Would it be an additional target, like NixOS, Home Manager, or nix-darwin: /docs/src/installation.md?

@brckd
Copy link
Contributor Author

brckd commented Jan 18, 2025

Yes, I think it would be neat to support this in Stylix. After all, we already support niche setups like Flatpak thanks to @brckd.

What would the implementation look like? Would it be an additional target, like NixOS, Home Manager, or nix-darwin: /docs/src/installation.md?

Yes, in contrast to Flatpak support it would be an additional target platform. Nix-on-droid has its own module system and would be able to import a stylix.nixOnDroidModules.stylix module. This module could also provide a home-manager integration using nix-on-droid's home-manager.sharedModules. I'm already working on a working implementation!

@brckd brckd linked a pull request Jan 18, 2025 that will close this issue
@brckd
Copy link
Contributor Author

brckd commented Jan 18, 2025

See #778!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or a feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants