-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README needs a little updating. #1
Comments
Actually I don't know since when, but they only mentioned in their documentation on SDK 33 release. I will update the README, and will also create unit tests, but for now I just added this to have some info how to use it. I only finished the package yesterday :) |
expo/expo#2556 For reference. |
Ok I see, but as I can understand limitations were coming from Android
So if data was larger than 2KB it may have failed (data was not saved) and except that nothing really happened, but in next SDK SecureStore will check the size and it will throw an error if data is larger, right? |
I'm honestly not sure where they got the 2KiB number from, you know. They tested on one device, and then halved it, I guess? But yeah, >2KiB will throw an error in future, "just because", to save silent errors and data loss. |
Ok so basically I just have to change that it will be a limitation from next SDK. Thanks :) |
The 2KiB limit has (kinda) always been present. A user noticed data loss issues when storing a lot in securestore, (about 80KiB), and raised an issue with Expo, who added the warning in SDK33.
Also, though I'm less sure of this, if this library is untranspiled, the README should have instructions as to how to exclude it from the transformIgnorePatterns for jest integration, as detailed here.
The text was updated successfully, but these errors were encountered: