Ngnix config file should be moved to the root of the repo #2086
ido777
started this conversation in
Feature Requests & Suggestions
Replies: 2 comments 5 replies
-
Not sure what you mean here, aren't you already talking about this in #2087 ? |
Beta Was this translation helpful? Give feedback.
0 replies
-
@fuegovic you are correct that my original post was not clear enough. Those are 2 different issues |
Beta Was this translation helpful? Give feedback.
5 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
What happened?
The nginx configuration file located at ./client/nginx.conf should be moved to either
./nginx.conf
./nginx/nginx.conf
For 4 reasons
(BTW A similar issue but less problematic is with ./mkdocs.yml that a better place might be
./docs/mkdocs.yml
or
./docs/src/mkdocs.yml
along with requirments.txt and read.MD file that will explain how to serve the documents (e.g. mkdocs serve -f ../../mkdocs.yml )
Steps to Reproduce
Nginx is a different entity than client entity and even if there were packed in the same docker(which is not the case today) still their source should be separated to avoid confusion.
What browsers are you seeing the problem on?
No response
Relevant log output
No response
Screenshots
No response
Code of Conduct
Beta Was this translation helpful? Give feedback.
All reactions