-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new RethinkDB 2.1 error type hierarchy #106
Comments
It seems that errors in js is to exceptions in php. Would you call them errors or exceptions? |
What I meant is just implementing an analogue of this rethinkdb/rethinkdb#4559 . |
(in all of the official RethinkDB drivers including the JS one each error type corresponds to one exception class) |
I saw that. I was asking if they shouldn't be renamed in php from "Errors" to "Exceptions"? |
Ah, got you. I think it would be better to stay close to the official exception names (so people can look at http://rethinkdb.com/docs/error-types/ and immediately understand what the corresponding exception in PHP-RQL is). I originally picked slightly different exception names from the official drivers when I first wrote PHP-RQL a few years ago, but wouldn't to the same again. It just increases the documentation work and makes the driver more confusing for users who have been reading the official documentation. |
This makes sense |
No description provided.
The text was updated successfully, but these errors were encountered: