Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new RethinkDB 2.1 error type hierarchy #106

Open
danielmewes opened this issue Sep 27, 2015 · 6 comments
Open

Support new RethinkDB 2.1 error type hierarchy #106

danielmewes opened this issue Sep 27, 2015 · 6 comments

Comments

@danielmewes
Copy link
Owner

No description provided.

@mbrevda
Copy link
Contributor

mbrevda commented Sep 30, 2015

It seems that errors in js is to exceptions in php. Would you call them errors or exceptions?

@danielmewes
Copy link
Owner Author

What I meant is just implementing an analogue of this rethinkdb/rethinkdb#4559 .
Currently we have the exception types RqlDriverError and RqlServerError. We should implement subclasses of these corresponding to the error types reported by RethinkDB 2.1.

@danielmewes
Copy link
Owner Author

(in all of the official RethinkDB drivers including the JS one each error type corresponds to one exception class)

@mbrevda
Copy link
Contributor

mbrevda commented Oct 7, 2015

I saw that. I was asking if they shouldn't be renamed in php from "Errors" to "Exceptions"?

@danielmewes
Copy link
Owner Author

Ah, got you.

I think it would be better to stay close to the official exception names (so people can look at http://rethinkdb.com/docs/error-types/ and immediately understand what the corresponding exception in PHP-RQL is).

I originally picked slightly different exception names from the official drivers when I first wrote PHP-RQL a few years ago, but wouldn't to the same again. It just increases the documentation work and makes the driver more confusing for users who have been reading the official documentation.

@mbrevda
Copy link
Contributor

mbrevda commented Oct 14, 2015

This makes sense

@danielmewes danielmewes modified the milestone: 2.2 Dec 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants