Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerating the proto files make the tests fail #640

Open
3 tasks done
AdrienVannson opened this issue Nov 11, 2024 · 1 comment
Open
3 tasks done

Regenerating the proto files make the tests fail #640

AdrienVannson opened this issue Nov 11, 2024 · 1 comment
Labels
bug Something isn't working investigation needed

Comments

@AdrienVannson
Copy link
Contributor

AdrienVannson commented Nov 11, 2024

Summary

Regenerating the proto files make the tests fail

Reproduction Steps

Re-generate the files used in the compiler, as documented in the README:

protoc \
    --plugin=protoc-gen-custom=src/betterproto/plugin/main.py \
    --custom_opt=INCLUDE_GOOGLE \
    --custom_out=src/betterproto/lib/std \
    -I /usr/include/ \
    /usr/include/google/protobuf/*.proto

Then, run poe generate and poe test

Expected Results

The tests should pass.

Actual Results

The test_struct test actually fails.

My guess is that the output files of the compiler have been manually edited to change the to_dict and from_dict methods of Struct (see https://github.com/danielgtaylor/python-betterproto/blame/master/src/betterproto/lib/std/google/protobuf/__init__.py#L2225 )

System Information

libprotoc 3.12.4
Python 3.12.6
Name: betterproto
Version: 2.0.0b7
Summary: A better Protobuf / gRPC generator & library
Home-page: https://github.com/danielgtaylor/python-betterproto
Author: Daniel G. Taylor
Author-email: danielgtaylor@gmail.com
License: MIT
Location: /[...]/.venv/lib/python3.12/site-packages
Editable project location: [...]
Requires: grpclib, python-dateutil, typing-extensions
Required-by:

Checklist

  • I have searched the issues for duplicates.
  • I have shown the entire traceback, if possible.
  • I have verified this issue occurs on the latest prelease of betterproto which can be installed using pip install -U --pre betterproto, if possible.
@AdrienVannson AdrienVannson added bug Something isn't working investigation needed labels Nov 11, 2024
@Gobot1234
Copy link
Collaborator

Yeah that's just gonna need removing I think or we need a custom generator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working investigation needed
Projects
None yet
Development

No branches or pull requests

2 participants