We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerating the proto files make the tests fail
Re-generate the files used in the compiler, as documented in the README:
README
protoc \ --plugin=protoc-gen-custom=src/betterproto/plugin/main.py \ --custom_opt=INCLUDE_GOOGLE \ --custom_out=src/betterproto/lib/std \ -I /usr/include/ \ /usr/include/google/protobuf/*.proto
Then, run poe generate and poe test
poe generate
poe test
The tests should pass.
The test_struct test actually fails.
test_struct
My guess is that the output files of the compiler have been manually edited to change the to_dict and from_dict methods of Struct (see https://github.com/danielgtaylor/python-betterproto/blame/master/src/betterproto/lib/std/google/protobuf/__init__.py#L2225 )
to_dict
from_dict
Struct
libprotoc 3.12.4 Python 3.12.6 Name: betterproto Version: 2.0.0b7 Summary: A better Protobuf / gRPC generator & library Home-page: https://github.com/danielgtaylor/python-betterproto Author: Daniel G. Taylor Author-email: danielgtaylor@gmail.com License: MIT Location: /[...]/.venv/lib/python3.12/site-packages Editable project location: [...] Requires: grpclib, python-dateutil, typing-extensions Required-by:
pip install -U --pre betterproto
The text was updated successfully, but these errors were encountered:
Yeah that's just gonna need removing I think or we need a custom generator
Sorry, something went wrong.
No branches or pull requests
Summary
Regenerating the proto files make the tests fail
Reproduction Steps
Re-generate the files used in the compiler, as documented in the
README
:Then, run
poe generate
andpoe test
Expected Results
The tests should pass.
Actual Results
The
test_struct
test actually fails.My guess is that the output files of the compiler have been manually edited to change the
to_dict
andfrom_dict
methods ofStruct
(see https://github.com/danielgtaylor/python-betterproto/blame/master/src/betterproto/lib/std/google/protobuf/__init__.py#L2225 )System Information
libprotoc 3.12.4
Python 3.12.6
Name: betterproto
Version: 2.0.0b7
Summary: A better Protobuf / gRPC generator & library
Home-page: https://github.com/danielgtaylor/python-betterproto
Author: Daniel G. Taylor
Author-email: danielgtaylor@gmail.com
License: MIT
Location: /[...]/.venv/lib/python3.12/site-packages
Editable project location: [...]
Requires: grpclib, python-dateutil, typing-extensions
Required-by:
Checklist
pip install -U --pre betterproto
, if possible.The text was updated successfully, but these errors were encountered: