Define ParseError as a dataclass #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #153 +/- ##
==========================================
- Coverage 97.61% 97.60% -0.01%
==========================================
Files 10 10
Lines 1214 1213 -1
==========================================
- Hits 1185 1184 -1
Misses 29 29 ☔ View full report in Codecov by Sentry. |
l00ptr
reviewed
Nov 28, 2024
pgiraud
force-pushed
the
errors_dataclass
branch
from
ff2f6ab to
946b137
Compare
Instead of magical args[0]
pgiraud
force-pushed
the
errors_dataclass
branch
from
946b137 to
6da3a65
Compare
dlax
reviewed
Dec 2, 2024
There was a problem hiding this comment.
I'm not sure defining exception classes as dataclass is a good idea; I've never seen this pattern. In particular, I am worried about the fact that the super-class constructor is no longer called, so that the args attribute, part of BaseException API, is empty. This might not be a very big deal in practice depending on what users do with the exception value, but this does not seem very clean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152