You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now, the aim of our library is to allow the user to reuse these "building blocks". So, say the user wants to build another model (not DCAN), and he/she wants to use TemporalBlock. They can load it directly from layers. We will have to generalise these building blocks though, to allow all kinds of inputs. I think this is where the strength of our library will lie - to enable the user to use these layers directly without copying the code separately. For example, DCAN uses the following Conv Block:
Another advantage of this is: we will have only the main model class in the respective model file. So, for DCAN, for example, inside src/modules/models/dcan.py, I will only have class DCAN. All layers/building blocks, etc. will be present in src/modules/layers/....
I think we should have a folder inside
src/modules
calledlayers
. Please see the example below to get a better idea:Consider the DCAN code (https://agit.ai/jsx/DCAN/src/branch/master/models.py). It has multiple "building blocks", namely,
WordRep
,TemporalBlock
, etc. (let's just consider these two layers for now).Now, the aim of our library is to allow the user to reuse these "building blocks". So, say the user wants to build another model (not DCAN), and he/she wants to use
TemporalBlock
. They can load it directly fromlayers
. We will have to generalise these building blocks though, to allow all kinds of inputs. I think this is where the strength of our library will lie - to enable the user to use these layers directly without copying the code separately. For example, DCAN uses the following Conv Block:The above code snippet is repeated twice here: https://agit.ai/jsx/DCAN/src/branch/master/models.py#L84
We can convert it to:
and reuse this without having to duplicate code. Moreover, the user can use this Conv Layer if he wants to build a DCAN-like model.
What do you guys think, @dalgu90, @SuhasShanbhogue?
The text was updated successfully, but these errors were encountered: