Only use "flashing" when redirecting #57
Assignees
Labels
Comments
josteinaj
added a commit
that referenced
this issue
Apr 14, 2016
This ensures that all browser windows get a unique browserId. Before this, if you duplicated a tab in chromium, both tabs would have the same browserId. As a consequence, only the first tab would be notified of a job completion for some reason, this seems to have fixed that. It also avoids having to use flashing to pass the browserId to the browser, which helps towards solving #57. This commit also makes sure that a browser window showing a job view only receives file uploads from that specific job. This was an issue if you tried creating multiple jobs simultaneously in separate browser windows.
josteinaj
added a commit
that referenced
this issue
Apr 15, 2016
This ensures that all browser windows get a unique browserId. Before this, if you duplicated a tab in chromium, both tabs would have the same browserId. As a consequence, only the first tab would be notified of a job completion for some reason, this seems to have fixed that. It also avoids having to use flashing to pass the browserId to the browser, which helps towards solving #57. This commit also makes sure that a browser window showing a job view only receives file uploads from that specific job. This was an issue if you tried creating multiple jobs simultaneously in separate browser windows.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm getting a flood of these warnings when running the Web UI.
So... I guess the Web UI shouldn't use flashing with status code 200 then...
Flashing is currently used to set the browserId, sending errors/success messages etc to the templates. The "proper" way of doing it is probably to send them as arguments to the templates instead.
The text was updated successfully, but these errors were encountered: