add indication that an option takes a value to the help message #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. correct determination of width of left help column; make leading indent
* A bug resulted in taking the width of a stringified array reference,
rather than the data in the array.
* The leading indent was a full tab, which is a lot of space. Reduce
it to 4 spaces.
2. The help message didn't specify that an option took a value.
Here's before and after for the option specification in t/11-usage.t
Usage: 11-usage.t [-rv] [long options] [arguments]
--bare
--define (default: arch=i386, isize=4)
--input (default: test.txt)
--libs (default: one, two)
-r recursive
--test run in test mode
-v, --verbose turn on verbose output (default: 2)
Usage: 11-usage.t [-rv] [long options] [arguments]
--bare <value>
--define key=<value> (default: arch=i386, isize=4)
--input <value> (default: test.txt)
--libs <value> (default: one, two)
-r recursive
--test run in test mode
-v [<value>], --verbose [<value>] turn on verbose output (default: 2)
|
Fixed the weird output of the last line in the help output; turns out the max width was being incorrectly calculated. Here's what it looks like now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The help message didn't specify that an option took a value.
Here's before and after for the option specification in t/11-usage.t