-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give client a Python interface #2
Comments
Sure; good idea, and a PR would be great! Actually, I have some cleanup to commit for the client that might help, which I'll try to complete in a day or two. |
@TMiguelT Cleanup complete. Also refactored some to ease external usage. |
if you could clearly describe about this issue, I will be very happy to become a contributor to this repo. |
@daanzu, thanks for the cleanup! I still believe there is some work that needs to be done though. The main thing this needs is the ability to import the client in another python package (@imkkk). For instance:
This would allow us to use the great VAD + DeepSpeech integration in another application, for example a custom web application. I've slowly started looking into making a PR for this though, so don't stress if none of you get the chance to do this. |
- add POST API for uploading a wav file - add enhanced metadata output option to ws and POST options - enhanced README with additional examples and changelog - not complete fix, but partially aimed at issue daanzu#2 (request for package) with API addition
The sound detection and websocket streaming you've implemented is fantastic. However I'm interested in using the client in another Python application. Do you think we could look into cleaning it up and making it importable? The CLI should stay obviously, but ideally there'd be a single entry point function that could be called by some other Python code, or by the CLI/argparse interface.
I'll write a PR for this if you're interested (and once I get some time).
The text was updated successfully, but these errors were encountered: