Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hinting to functions #2571

Open
f0lie opened this issue Dec 11, 2023 · 1 comment
Open

Add type hinting to functions #2571

f0lie opened this issue Dec 11, 2023 · 1 comment

Comments

@f0lie
Copy link

f0lie commented Dec 11, 2023

Sometimes it's hard to understand the intent of the code without type hints. It would help a lot in understand the the pieces of code that is added to classes.

It would likely take a while to migrate all functions to type hinting, but it's still worth discussing it in a bug.

@hiepdang-ml
Copy link

Agree! I found the book has great content but the code was poorly written by not following coding standards. No docstrings, no code comments, no type hints, poorly named variables. I hope they will rework on the code in later versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants