Node label flickering when animating font-size

[likeamike]

Environment info

• Cytoscape.js version : 3.30.2
• Browser/Node.js & version : Chrome Version 128.0.6613.85 (64-bit), Firefox 129.0.2 (64-bit), Node v20.13.1

Current (buggy) behaviour

What does the bug do?

When I try to add a hover effect to a node to enlarge the font size, the node's label blinks. Specifically, when I hover over one node, the label of another node or both nodes start blinking.

node.blinking.mp4

Desired behaviour

What do you expect Cytoscape.js to do instead?

Node labels should remain stable and not blink when hovering over another node.

Minimum steps to reproduce

What do you need to do to reproduce the issue?

1. Hover over the nodes.
2. If everything appears fine initially, refresh the page and hover over the nodes again.

The issue is reproduced here: https://jsbin.com/narayik/edit?html,css,js,output

Fork/clone this JSBin demo and reproduce your issue so that your issue can be addressed quickly and effectively:
http://jsbin.com/fiqugiq

For reviewers

Reviewers should ensure that the following tasks are carried out for incorporated issues:

• Ensure that the reporter has included a reproducible demo. They can easily fork this JSBin demo: http://jsbin.com/fiqugiq
• The issue has been associated with a corresponding milestone.
• The commits have been incorporated into the corresponding branches. Bug-fix patches go on
  • master,
  • unstable, and
  • the previous feature release branch (e.g. 1.1.x if the current release is 1.2).
• The issue has been labelled as a bug, if necessary.

[mikekucera]

By "blinking" you are referring to the non-smooth resizing animation that sometimes happens?

[mikekucera]

Removed the workaround in this comment because there is a better one below...

[mikekucera]

I’ve managed to diagnose the problem.

The bug can be triggered just by animating the font size, and you only need one node. It has nothing to do with mouse inputs or hovering.

I created a looping animation with a single node like this…

var node = cy.getElementById('a');
var expand = true;
var duration = 1000;
var timeout = duration + 100;

function testAnimate() {
  if(expand) {
    node.animate({
      style: {
          'font-size': '12px',
      }, 
      duration: duration,
      queue: false,
    });
    expand = false;
  } else {
    node.animate({
      style: {
          'font-size': '10px',
      }, 
      duration: duration,
      queue: false,
    });
    expand = true;
  }
  setTimeout(testAnimate, timeout);
}
setTimeout(testAnimate, timeout);

Eventually the weird flickering behaviour will start to show up.

The problem is that animating the font size like this causes the renderer’s labelDimCache to fill up as it calculates and saves label dimensions for every frame of the animation. In my tests the cache can grow to about 400-500 entries for this 1 second looping animation.

The reason the flicker happens is because of a cache collision. It calculates a cache key which just happens to be shared with a different label size, and pulls the wrong dimensions from the cache. That frame of the animation gets the wrong label size and that causes the flicker.

I’m going to hand this one off to @maxkfranz for now, as he is way more familiar with the style hashing code. I’m not sure why the hashes are colliding and I would need some time to dig through the code to understand it.

In the meantime there is a workaround. Add a complete function to the animation options like this…

node.animate({
    style: {
        'font-size': '10px',
    }, 
    duration: duration,
    queue: false,
    complete: () => { cy.renderer().labelDimCache = []; }  // clear the label dimensions cache
});

That will clear out the cache after each animation. Warning, the labelDimCache field is not public API. This might harm performance on a large graph, but for a small one it should be fine. If it still doesn’t fix it then use step instead of complete.

[likeamike]

Thank you, @mikekucera, for your diagnostic.
I just want to mention that the workaround doesn't really work for me. I've tried both "complete" and "step," and neither of them fixes the flickering. Additionally, I still have two nodes because the problem with animated font resizing might affect not only the target node that is resizing but also other nodes that should not have any changes.

flickering.mp4

[maxkfranz]

@likeamike I put together a WIP PR with an idea for a fix based on @mikekucera's diagnosis, but I didn't have time to test it. Try the PR and let us know if it makes a difference for you

#3298