-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tilingPadding functions should take an argument which is the node for which the padding is being calculated #46
Comments
Actually to be consistent with every other layout, CoSE should allow for per-element functions for every possible field in the options object. The majority options could support this; only a small number absolutely must be layout-global options. |
Even better :) |
The other layouts do something like this. With a function, it's not that hard to support. let optVal = ( name, ele ) => {
let field = options[name];
if( isFunction( field ) ){
return field( ele );
} else {
return field;
}
};
// e.g.
let edgeLength = optVal( 'edgeLength', edge ); @metincansiper Could this approach be used in the layout? |
@maxkfranz sorry I just realized this. I think in general per-element functions would be supported in this layout by attaching result of I think that tiling padding options namely Also the padding values assigned in the same line About whether the options like |
This would allow us to determine what kind of tiling padding we want on a per-node basis :)
The text was updated successfully, but these errors were encountered: