fix: 29687 an issue where parent width/height if 0 but with children textContent evaluates as hidden when it's visible

[senpl]

• Closes Parent width should not signal element hidden when it's visible #29687

Additional details

This is necessery to be consistent with what users see in browsers.

Steps to test

<div id="id2">
	<div style="width: 0">
		<p class="big">IN SECTION 2 </p>
	</div>
</div>

expect(cy.$$('#id2 >div > p')).to.be.visible
    
cy.get('#id2 >div > p').click()

How has the user experience changed?

Some elements that previously was marked as hidden now are will correctly be marked as visible

PR Tasks

• Have tests been added/updated?
• [] Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[senpl]

It was done similar in the past as could be seen in #5974

[senpl]

One test updated because element that was in test in fact was visible, and incorrectly exected to be hidden and not visible.

[jennifer-shehane]

@senpl There a failure regarding visibility in the tests.

[senpl]

Now looks like cert errors, so probably something with pipeline.

[jennifer-shehane]

We've decided to prioritize looking into these visibility fixes in Quarter 4 of this year, when we intend to spend time on Cypress 14 release. It will ease any concerns we have around releasing breaking changes with these fixes and also help us plan the proper time to review these. Tracking here: #29925

[jennifer-shehane]

Updated the base branch to go against release/14.0.0

[jennifer-shehane]

I'll leave some notes here on where I left off on this.

Essentially, there are some circumstances where elements should be considered visible/hidden depending on the state of their child node that is a TEXT node. And Cypress is not taking those situations into account today.

• If an element has a child text node that contains characters other than whitespace characters, that content makes it visible (even if there is no width/height of the element), unless the element itself is explicitly hidden OR the text node is hidden by the element, like the element having overflow: hidden and the text node being clipped.

^ this last part in highlighted text is not currently being accounted for in the logic, which is why there is a failing test. I'm not sure if there are other circumstances that this updated code doesn't account for. Essentially the Cypress logic never seemed to be taking into account TEXT nodes, we've only been accounting for actual element nodes.