-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in CONTRIBUTING.md #5452
Comments
This is about CONTRIBUTING.md > Committing code in the https://github.com/cypress-io/cypress repo, so the issue should perhaps be moved there. I would assume that there are some words missing in the sentence. Maybe it is trying to say something like the following? "If you make changes to an npm package that can't be published until the main Cypress binary is also updated, you should make a pull request against the |
Thanks for the feedback, @MikeMcC399. I was not able to create an issue of the proper type within the code repo, because only issues of types 🐛Bug report, ⬇️ Issue during install, ✨ Feature and ❄️ Flaky test in |
Your suggestion is what I have done in the past when I reported problems in the CONTRIBUTING.md file on the main repository. Use the bug report and modify it accordingly. |
Okay, thanks! Closing this issue then. |
Subject
Guides (CONTRIBUTING.md)
Description
The sentence "If you make changes to an npm package that can't be published until the binary is also updated, you should make a pull request against specifying this is not be merged until the scheduled Cypress app release date." in file CONTRIBUTING.md is hard to understand because of incorrect grammar.
The text was updated successfully, but these errors were encountered: