Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting information for minimum Chrome version 64 or 80 #5446

Closed
MikeMcC399 opened this issue Aug 28, 2023 · 7 comments · Fixed by #5891
Closed

Conflicting information for minimum Chrome version 64 or 80 #5446

MikeMcC399 opened this issue Aug 28, 2023 · 7 comments · Fixed by #5891
Assignees
Labels
content: rewrite triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team.

Comments

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Aug 28, 2023

Subject

Guides > Launching Browsers > Chrome Browsers

Description

In the section Guides > Launching Browsers > Chrome Browsers it states:

All Chrome* flavored browsers will be detected and are supported above Chrome 64.

This contradicts the information in Guides > Launching Browsers > Browser versions supported in a previous section on the same page which says:

Cypress supports the browser versions below:

Chrome 80 and above.

The documentation is therefore inconsistent and should be changed to state the same minimum Chrome version in all places - either 64 or 80.


In terms of how Cypress is actually operating:

https://github.com/cypress-io/cypress/blob/0f9a150647146c3e63e14d298d7fcf7ad5c92b66/packages/launcher/lib/known-browsers.ts#L3-L10 shows:

// Chrome started exposing CDP 1.3 in 64
export const MIN_CHROME_VERSION = 64

// Firefox started exposing CDP in 86
export const MIN_FIREFOX_VERSION = 86

// Edge switched to Blink in 79
export const MIN_EDGE_VERSION = 79

so it appears that a minimum version of Chrome 64 is enforced in Cypress 13.x, not a minimum version of 80.

@nagash77 nagash77 added the triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. label Aug 29, 2023
@jaffrepaul
Copy link
Contributor

@jennifer-shehane same on this one. Can you confirm the update?

@MikeMcC399

This comment was marked as outdated.

@jennifer-shehane
Copy link
Member

I feel like there is a restriction that doesn't allow it to function after Chrome 80 that was introduced in v10. I can't remember exactly what it was nor can I find it. I'm fine with 80 though.

Our previous strategy was to put the minimum version that Cypress will work - like we KNOW it breaks and doesn't function before that.

If we want our strategy to be moreso - 'we will not support issues from these older browsers and work with you on it', then we could put a later Chrome version. Honestly the instances of issues I've seen on really old browsers feels pretty small, or nonexistent though....so I'm not sure this is an active problem.

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

@jennifer-shehane
Copy link
Member

@MikeMcC399 Yes, this sounds fine to me

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane
Copy link
Member

Yes! There it is!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content: rewrite triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants