Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated references to x-cypress-matched-blacklisted-host #5439

Closed
MikeMcC399 opened this issue Aug 25, 2023 · 2 comments · Fixed by #5440
Closed

Outdated references to x-cypress-matched-blacklisted-host #5439

MikeMcC399 opened this issue Aug 25, 2023 · 2 comments · Fixed by #5440

Comments

@MikeMcC399
Copy link
Contributor

Subject

Configuration > blockHosts

Description

docs-blockHosts

docs-legacy-blockHosts

both show an outdated screen shot blocked-host.png

the header shows the outdated text x-cypress-matched-blacklisted-host

This was changed in Cypress 5.0.0 through PR cypress-io/cypress#7622 from x-cypress-matched-blacklisted-host to x-cypress-matched-blocked-host (defined in
https://github.com/cypress-io/cypress/blob/65cb16f900cc85175ad17859e8bee2a3b28ba044/packages/proxy/lib/http/request-middleware.ts#L334).

Suggestion

  1. Replace screenshot https://github.com/cypress-io/cypress-documentation/blob/main/static/img/guides/references/v10/blocked-host.png with a new one showing both 503 Service Unavailable and the correct x-cypress-matched-blocked-host text which matches the example using blockHosts:
www.google-analytics.com
*.google-analytics.com
*google-analytics.com

blocked-host

  1. Correct text in References > Configuration > Notes > blockHosts to refer to x-cypress-matched-blocked-host
@MikeMcC399
Copy link
Contributor Author

I plan to pick this up and submit a PR to correct this issue.

@MikeMcC399
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant