Add Support for Wait For Element Step #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
Any news on this? @Who-Code first of all, thanks for adding it!. Then maybe you can clean your commits, because this project use yarn and there are already a yarn.lock file, that's means you can remove your package-lock.json, then there is console.log at line console.dir(step); 🙏🏽 And I do not know if you need to mark this PR as a Ready for Review |
|
@Who-Code Thanks for the contribution. I'll see if someone has time to look at this next sprint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Wait For Element Steps from Chromes .json are not generated in the cypress test file.
This PR adds the basic functionality by generating .should('be.visible') including a timeout for the selector.