Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass original commit status information #20

Open
bahmutov opened this issue Apr 8, 2019 · 1 comment
Open

Pass original commit status information #20

bahmutov opened this issue Apr 8, 2019 · 1 comment

Comments

@bahmutov
Copy link
Contributor

bahmutov commented Apr 8, 2019

When creating JSON block for other operations, also pass original repo information so we can set status back

Right now

const commitMessageInstructions = getInstallJson(
  npm,
  env,
  platform,
  shortNpmVersion, // use as version as branch name on test projects
  commitInfo && commitInfo.sha
)
const jsonBlock = toMarkdownJsonBlock(commitMessageInstructions)

Note that produces block has the commit SHA

Screen Shot 2019-04-08 at 3 22 36 PM

@bahmutov
Copy link
Contributor Author

bahmutov commented Apr 8, 2019

probably just an object with

{
  status: {
    owner // GitHub organization owner
    repo // GitHub repo
    sha // commit sha to report on
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant