Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge example incorrectly published #498

Open
MikeMcC399 opened this issue Nov 13, 2024 · 0 comments
Open

Edge example incorrectly published #498

MikeMcC399 opened this issue Nov 13, 2024 · 0 comments
Labels
documentation type: bug 🐛 Something isn't working

Comments

@MikeMcC399
Copy link
Collaborator

Issue

The published Edge Usage Example is incorrect and does not work:

version: '2.1'
orbs:
  cypress: cypress-io/cypress@3
jobs:
  edge-test:
    executor: cypress-browsers
    steps:
      - cypress/install
      - cypress/run-tests:
          cypress-command: npx cypress run --browser edge
          start-command: npm run start:dev
workflows:
  use-my-orb:
    jobs:
      - edge-test

It is missing the executors section

executors:
  cypress-browsers:
    docker:
      - image: cypress/browsers:node-20.17.0-chrome-129.0.6668.70-1-ff-130.0.1-edge-129.0.2792.52-1

Background

The example source code in src/examples/edge.yml is:

description: >
  Run Cypress tests in Microsoft Edge.
usage:
  version: 2.1
  orbs:
    cypress: cypress-io/cypress@3
  executors:
    cypress-browsers:
      docker:
        - image: cypress/browsers:node-20.17.0-chrome-129.0.6668.70-1-ff-130.0.1-edge-129.0.2792.52-1
  jobs:
    edge-test:
      executor: cypress-browsers
      steps:
        - cypress/install
        - cypress/run-tests:
            start-command: "npm run start:dev"
            cypress-command: 'npx cypress run --browser edge'
  workflows:
    use-my-orb:
      jobs:
        - edge-test

The runnable part of this code is

version: 2.1
orbs:
  cypress: cypress-io/cypress@3
executors:
  cypress-browsers:
    docker:
      - image: cypress/browsers:node-20.17.0-chrome-129.0.6668.70-1-ff-130.0.1-edge-129.0.2792.52-1
jobs:
  edge-test:
    executor: cypress-browsers
    steps:
      - cypress/install
      - cypress/run-tests:
          start-command: "npm run start:dev"
          cypress-command: 'npx cypress run --browser edge'
workflows:
  use-my-orb:
    jobs:
      - edge-test

However circleci orb pack ./src drops the executors section resulting in a non-working workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant