Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace httr with httr2 #712

Merged
merged 2 commits into from
Oct 2, 2023
Merged

refactor: replace httr with httr2 #712

merged 2 commits into from
Oct 2, 2023

Conversation

maelle
Copy link
Member

@maelle maelle commented Sep 25, 2023

Fix #708

@krlmlr
Copy link
Contributor

krlmlr commented Sep 30, 2023

Is this ready to go?

@maelle maelle marked this pull request as ready for review October 2, 2023 07:38
@maelle
Copy link
Member Author

maelle commented Oct 2, 2023

Or we wait until we have tests for that part, as it's ready in theory.

@maelle
Copy link
Member Author

maelle commented Oct 2, 2023

or do you have a package (using fledge) that you'll soon submit to CRAN, where you could use this branch @krlmlr?

@krlmlr krlmlr merged commit 12fb287 into main Oct 2, 2023
12 checks passed
@krlmlr krlmlr deleted the httr2 branch October 2, 2023 11:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use httr2 instead of httr
2 participants
@maelle @krlmlr