Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add formal tests #103

Closed
krlmlr opened this issue Aug 2, 2021 · 5 comments
Closed

Add formal tests #103

krlmlr opened this issue Aug 2, 2021 · 5 comments
Labels
auto 🚗 debt Technical debt
Milestone
3.0.0: Automation...

Comments

@krlmlr
Copy link
Contributor

krlmlr commented Aug 2, 2021

wherever possible.

One problem/feature with snapshot testing of vignettes is that these tests don't count for the coverage.
@krlmlr krlmlr added this to the 0.1.1 milestone Aug 2, 2021
@maelle
Copy link
Member

maelle commented Sep 23, 2021

Might happen with examples so maybe partly in 0.1.0? #113 adds a test.

@maelle maelle mentioned this issue Sep 23, 2021
Closed
@krlmlr krlmlr modified the milestones: 0.1.1, 0.1.2 May 12, 2022
@krlmlr
Copy link
Contributor Author

krlmlr commented May 19, 2022

This and many many other issues will be much easier with #331.

@krlmlr krlmlr modified the milestones: 0.1.2, 0.1.3 May 20, 2022
@maelle maelle added the debt Technical debt label Jan 2, 2023
@maelle
Copy link
Member

maelle commented Sep 25, 2023

What else exactly would be tested?

@maelle maelle mentioned this issue Sep 25, 2023
Open
4 tasks
@krlmlr
Copy link
Contributor Author

krlmlr commented Sep 26, 2023

We're good here, let's continue in the new wishlist issue.

@krlmlr krlmlr closed this as completed Sep 26, 2023
@github-actions GitHub Actions
Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
auto 🚗 debt Technical debt
Milestone
3.0.0: Automation, next gen
Development

No branches or pull requests
2 participants
@krlmlr @maelle