-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a spinner or overlay when mutations are triggered #342
Comments
I think disable the button, add a pop-up/overlay. Once Cylc Flow returns subscription IDs for mutations we will be able to track the progress of requests. In the design document under the "Api On The Fly" section there is an overview of how this could look. The idea being that once a mutation is triggered a pop-up/overlay appears with a spinner displaying the status of the mutation. The overlay could have a "minimise" option which allows the overlay to be minimised into the "commands" box (the "reload", "poll" and "kill" commands could take a while to complete). So if you tried to stop the suite (even if via the button on the toolbar) you should get the overlay. Messages should appear something like this:
|
Oh, I see the "command queued" in the api on the fly example.
On the sketches, there is a message next to the "Control" button (Toolbar). Is that where these messages should go? |
Yeah, that was the idea. This is all blue-skies and subject to some thought and design. Idea is to:
So a pop-up/overlay is great but we might need to minimise it in a way where the user can return to it later. (FYI we should do something similar with the CLI too) |
Describe exactly what you would like to see in an upcoming release
At the moment, when a user clicks on hold, release, or stop Toolbar buttons, there is no visual feedback to the user in the UI. Users are still able to see what is going on by inspecting browser network, or workflow logs.
But we should add a way to tell users to not worry, that the mutation was executed successfully - or not.
Additional context
Related to #87 I think. @oliver-sanders I thought in a few alternatives:
Any other ideas? This could be applied to other parts of the design, such as tooltip buttons like Trigger/Reset/Hold/Remove/etc.
Pull requests welcome!
The text was updated successfully, but these errors were encountered: