Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error handling: Network error #329

Open
oliver-sanders opened this issue Dec 10, 2019 · 4 comments
Open

error handling: Network error #329

oliver-sanders opened this issue Dec 10, 2019 · 4 comments
Milestone
Pending

Comments

@oliver-sanders
Copy link
Member

oliver-sanders commented Dec 10, 2019 •
edited
Loading

Address the error component of #111

Handle:

  • Network errors
  • GraphQL/UIS errors

Issues with communication to the UI Server typically manifest in the somewhat cryptic:

Network error: JSON.parse: unexpected character at line 4 column 1 of the JSON data

Presumably the error returned isn't valid JSON, we should catch the JSON.parse error so we can present / handle the actual error properly.

Pull requests welcome!
@oliver-sanders oliver-sanders added this to the 1.0 milestone Dec 10, 2019
@kinow
Copy link
Member

kinow commented Dec 10, 2019 •
edited
Loading

+1 I've been waiting for the websockets to fix this one. Related to #93

The idea would be to have an indicator when the server is offline. Apache Jena's Fuseki, Riot WebIM, and other projects have a similar feature.

@oliver-sanders oliver-sanders mentioned this issue Dec 16, 2019
Closed
@kinow
Copy link
Member

kinow commented Mar 18, 2020

@oliver-sanders not sure if the network connectivity indicator is enough to close this? Or should we do something else in case of network errors?

@oliver-sanders
Copy link
Member Author

It solves point 1, I think we could do with handling GraphQL errors better though.

@kinow
Copy link
Member

kinow commented Mar 19, 2020 •
edited
Loading

It solves point 1, I think we could do with handling GraphQL errors better though.

Related issue from Cylc UI Server: cylc/cylc-uiserver#68

@kinow kinow modified the milestones: 1.0, 2.0 Sep 10, 2021
@oliver-sanders oliver-sanders modified the milestones: 2.0.0, Pending Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Pending
Development

No branches or pull requests
2 participants
@kinow @oliver-sanders