Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query ownership #304

Closed
kinow opened this issue Nov 8, 2019 · 8 comments
Closed

Query ownership #304

kinow opened this issue Nov 8, 2019 · 8 comments

Comments

@kinow
Copy link
Member

kinow commented Nov 8, 2019

Describe exactly what you would like to see in an upcoming release

At the moment, it is hard to tell which GraphQL query is being executed. Looking at the #301 PR, the App.vue has a query (which may change as that PR is still under review, and maybe GScan.vue is a better place to move that query to).

However, you cannot inspect the objects with Vue Dev Tools browser extension. The component in App uses a const QUERIES declared outside of the component.

The query is then used in a singleton workflowService imported from a module, also not viewable in the browser extension. The queries are logged in the console, but the object structure is complicated.

The only way to really tell which query is being executed is through the Network tab, but that makes it harder to troubleshoot when you are not sure whether the query has been changed or not.

Additional context

Pull requests welcome!

@kinow kinow added this to the 1.0 milestone Nov 8, 2019
@kinow
Copy link
Member Author

kinow commented Nov 8, 2019

We have an $apolloData also added by a dependency (vue-apollo maybe?), but its queries attribute is empty. Maybe we could just change workflowService to populate that field.

image

@oliver-sanders
Copy link
Member

The information we need is in the workflowService which can tell you where each query came from and what the merged result is. I guess it's just finding a way to get that information out.

Perhaps a view?

@oliver-sanders
Copy link
Member

Coming back to this I quite like the idea of having some developer views:

  • One showing the active queries and the merged resultant query?
  • One for graphiql?

@kinow
Copy link
Member Author

kinow commented Dec 24, 2019

That would eliminate the need for the console.debug statements we have now. Bonus points if we can make it some way that users would be able to use and share their queries when reporting problems.

@oliver-sanders
Copy link
Member

share their queries when reporting problems.

Oooh.

This was referenced Jan 3, 2020
@oliver-sanders
Copy link
Member

oliver-sanders commented Jan 3, 2020

Punted to new issues, is #351 enough to superseded this issue?

@hjoliver
Copy link
Member

hjoliver commented Jan 3, 2020

Punted to new issues, is #351 enough to superseded this issue?

Seems to me it is; but @kinow will know better 😁

@kinow
Copy link
Member Author

kinow commented Jan 3, 2020

Way easier to work on these smaller issues now. Thanks @oliver-sanders ! Closing.

@kinow kinow closed this as completed Jan 3, 2020
@kinow kinow removed this from the 1.0 milestone Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants