-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task status icon tweak proposal #194
Comments
Trying to kill two birds with one stone:
rationale
I don't agree with the suggestion that we represent "ready" as "waiting" in the UI because:
Finally, representing "ready" as queued (which again, it is) is good because "queued" is generally understood to mean "waiting in line to be actioned". Whereas, "ready" is |
If need be we can distinguish between the two queue cases:
... by attaching a badge to one icon, or using a different number or shape of dots. Or perhaps it would be enough to explain in words when the user accesses additional info about a task |
Oh, good point! Since we already have i18n, +1 for a graphical representation instead. |
Sounds good to me. +1, not sure about distinguishing between types of queued... but at least UI-wise, sounds like a good idea. |
I really like this proposal in general, especially the drive to make the icons language agnostic.
I'm just thinking the job submission queue case is a stage approaching submission which then all being well goes to running with the progress bar, so in light of that perhaps the same "ellipsis" dot design but with a solid bar at the running-stage "zero progress" upwards-vertical position indicating that the execution is "blocked" from progressing to & within execution in the external subprocess queue? I.e. the leftmost design here (where I included some other possibilities for the different icon option too): |
@sadielbartholomew - good ideas!! but my initial thoughts are:
However, you've given me another idea here! "queued" and "ready" (the current state names) are both technically queue states, but they are not actually independent. Jobs are released from internal queues (if used) to the job submission (subprocess pool) queue. So, I think this would be both simple and progressive: |
(And, users can still distinguish when the sub-process pool is getting overloaded). |
Wouldn't a combination of dots and colours be easier to distinguish perhaps? I think if you had a few tasks near to each other, telling apart 2 to 3 dots could be hard too? |
Well, that's a point, but:
|
On the other hand, if using internal queues that will be the most commonly seen queued state by far, so it might be nice to have 3 dots rather than 2 for that. Which kind of supports your idea @kinow What about 3 dots for both, but a different colour for "ready" - because that is a more critical state (too long in that state means the process pool is crammed) |
Sounds good to me. And it's not too hard to change it later if we realize it didn't work well. |
Now adding in @sadielbartholomew's idea 💐 : |
Nice thinking @hjoliver, I do like the progressive designs as they make the standard flow between states nice & clear, will have a seamless transformation in displayed image, & will lend nicer to eventual features to notify users of transitions between states (#127).
I'm not keen on the idea of using colour, except perhaps the grey colour we have for the angular progress bar in the running state icon. We should, & believe it is the agreed plan from the Design Issue #87, reserve colour for job states & for family (etc.) groupings, to make those important aspects stand out amongst the wealth of other information. |
I get the motivation and I do kinda like the 321go thing but I think the dots are getting way too confusing in an icon which is already too complex. A couple ideas to prevent complicating the symbol:
|
These icons look nice @oliver-sanders ! Does it matter that the queued and held would have a similar badge (not sure how to call it?). While queued has the three bars (similar to hamburger menu icon), the held has the pause symbol I think. |
I mean, the held (in the |
Wan't actually proposing that particular icon just the notion of displaying the queued status separately. Was thinking about this the other day as it would be good to provide more information than just "task is queued":
Would be good to have some kind of an icon to go to for that information. Another option might be to represent the queue similarly to an xtrigger as a prerequisite external to the suite graph.
Mmm, we could but it only makes sense for a task to be queued in the following states:
|
Ah, I don't follow you there. Waiting (for prerequisites to be satisfied) is not queued. Retry is not a queue either, it's just individual tasks waiting for a time interval to come up. |
I mean that a running task could never be thought of as queued. That queued is kinda a special state so it might not make sense to chip it off in the way we have done for "held". |
OK let's really try to simplify the UI here. I think we can absorb the current The thing is, under non-exceptional circumstances all that users care about is:
Waiting is not a queued state (see above; and users need to know if prerequisites are satisfied or not), but task has satisfied prereqs but is not running yet is actually a succession of three queues: internal queues ('queued'), then subprocess queue ('ready'), then batch system queue ('submitted'). So why not just condense the three queue states in the middle into a single
Exceptional states ( What could be simpler than that? 💥 |
OK we agree on that. But, in the context of this discussion I think you were playing a bit fast and loose with the term "waiting" there! It has never meant "waiting to run", only the much narrower "waiting for prerequisites to be satisfied". |
Good.
Agreed, my original idea for task icons was "inactive", "active" and "completed".
Like this? |
BTW I anticipate that absorbing
|
@oliver-sanders - missed your previous post while I was typing!
YES - I love it! So simple. |
Yes, I'd forgotten about that - sorry it took me so long to see the light 😬 |
I suppose we don't even have to give the UI queued/ready/submitted icon a single name (I have been calling it "queued") The three internal states can just be mapped to the same icon, in the UI code. |
Self-analysis: I think I was originally concerned that merging status icons like this in the UI would inevitably hide important internal distinctions that users do sometimes need to know about (e.g. what it means if tasks stay too long in the ready state - sub-process pool is maxed out). But clearly that's not necessarily the case (just query the queued/ready/submitted icon for more detail). |
Yes, I've come to similar conclusions. For me "important internal distinctions" means triggerable states. |
I was also concerned about that ... but of course the job status icon allows us to distinguish submitted from the other "queued" task states. |
I'll close this Issue as superseded, so we don't have to re-read the laborious journey to this point. |
The text was updated successfully, but these errors were encountered: