Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy functional testing #59

Open
wxtim opened this issue May 10, 2021 · 0 comments
Open

Tidy functional testing #59

wxtim opened this issue May 10, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@wxtim
Copy link
Member

wxtim commented May 10, 2021

A number of functional tests use the pattern:

@pytest.fixture
def workflow_creation_fixture:
    ...
    yield {...info...}

@pytest.fixture
def run_some_cylc_program(workflow_creation_fixture):
    ...
    yield {...more info..., 'workflow_creation_fixture': workflow_creation_fixture}

This would be better if the second fixture yielded:

    yield {...more info..., **workflow_creation_fixture}

to avoid unnecessary nesting.

Pull requests welcome!

@wxtim wxtim added enhancement New feature or request good first issue Good for newcomers labels May 10, 2021
@wxtim wxtim added this to the later milestone Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant