-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-flake tests (Avoid cleanup errors when using -n > 1) #333
De-flake tests (Avoid cleanup errors when using -n > 1) #333
Conversation
c6202ed
to
d1f5cab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran the tests locally using pytest -n 5
and ended up with a bunch of leftover cylc-rose-test-2024...
dirs in ~/cylc-run
I don't think it's related?
|
Nor do I, but @oliver-sanders doesn't think that the message you are referring to was the one he was referring to when raising the issue. |
Tests no longer flaky. |
To avoid confusion, there seem to be 2 different flakes happening.
I think you were trying to solve no. 2, which I still encounter. |
Closes #325
Only run clean up tests in controller worker to prevent cleanup errors: Flaky tests were being caused by errors in cleanup when tests were distributed and some workers attempted to cleanup before other workers were finished with the same fixture.
Tested by running:
I have also checked that
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).CHANGES.md
entry included if this is a change that can affect users?.?.x
branch.