From ccde8377d8332fcddd62c9a23e31325bf3a8ddc6 Mon Sep 17 00:00:00 2001 From: Oliver Sanders Date: Tue, 19 Sep 2023 14:29:36 +0100 Subject: [PATCH] actions: exclude mypy with more recent python version * matplotlib has not dropped Python 3.7 support. * mypy produces a false positive error when scanning the installed matplotlib code (even though no_silence_site_packages=false). * cylc is still compatible with the more recent matplotlib releases, it's down to the installer (pip/conda/whatever) to install a version that's compatible with the python interpretter so there's no reason to put an upper pin in the metadata. --- .github/workflows/test_fast.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test_fast.yml b/.github/workflows/test_fast.yml index 6cc1ebb6c14..821760f9e5b 100644 --- a/.github/workflows/test_fast.yml +++ b/.github/workflows/test_fast.yml @@ -58,8 +58,10 @@ jobs: flake8 etc/bin/shellchecker + # note: exclude python 3.10+ from mypy checks as these produce false + # positives in installed libraries for python 3.7 - name: Typing - if: startsWith(matrix.os, 'ubuntu') + if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.python-version, 3.9) run: mypy - name: Doctests