Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation about adding custom metrics seems outdated #605

Open
markwort opened this issue Dec 20, 2024 · 0 comments
Open

documentation about adding custom metrics seems outdated #605

markwort opened this issue Dec 20, 2024 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation metrics Metrics related issues

Comments

@markwort
Copy link
Contributor

Describe the bug
As far as I can tell, the documentation for custom metrics is outdated.
In pgwatch2, the metrics where either in a database, or in /etc/pgwatch/metrics/<metricname>/<min_supported_pg_version>/metric.sql , but it seems to me that there are no longer places in the code that can read these.

Here the old /etc/pgwatch/metrics/ path is still referenced:
https://pgwat.ch/latest/reference/metric_definitions.html#for-yaml-based-setups

However, there seems to be nothing shipped by the pgwatch releases to populate that path.

Expected behavior
There should be a working way to add custom metrics, both for push and pull configuration, and it should be documented.
Maybe the only sane way to do this is to create a custom_metrics.yaml file (similar to metrics.yaml file) and have it loaded by pgwatch.

Best regards
Julian

@markwort markwort added documentation Improvements or additions to documentation metrics Metrics related issues labels Dec 20, 2024
@pashagolub pashagolub self-assigned this Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation metrics Metrics related issues
Projects
None yet
Development

No branches or pull requests

2 participants