Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cvx.simulator is missing? #27

Open
labgottedammerung opened this issue Jan 17, 2024 · 6 comments
Open

cvx.simulator is missing? #27

labgottedammerung opened this issue Jan 17, 2024 · 6 comments

Comments

@labgottedammerung
Copy link

Hello, I'm trying to follow the code and it appears that cvx.simulator is missing? It would be very neat to take a look at that if possible.

@yigaza
Copy link

yigaza commented Feb 21, 2024

from cvx.simulator.trading_costs import TradingCostModel
ModuleNotFoundError: No module named 'cvx.simulator'

portfolio.py can be found at:
https://github.com/cvxgrp/simulator/blob/main/cvx/simulator/portfolio.py
but trading_costs.py is missing?

@tschm
Copy link
Collaborator

tschm commented Feb 22, 2024

@kasperjo: Let's add some simple tests here. Current versions of the simulator do not contain a trading cost model.
@kasperjo: Chat later today? 9am PST?

@yigaza
Copy link

yigaza commented Feb 22, 2024

and data directory is missing?
PERMNO_to_COMNAM = pd.read_csv("../data/PERMNO_to_COMNAM.csv", index_col=0)
with open("../data/PERMNO_TO_SECTOR.json") as f:
PERMNO_TO_SECTOR = json.load(f)

@tschm
Copy link
Collaborator

tschm commented Feb 22, 2024

The problem with the data is that we can not share it in its complete form

@yigaza
Copy link

yigaza commented Feb 22, 2024

The problem with the data is that we can not share it in its complete form

Thanks! May little simulate sample data?

@kasperjo
Copy link
Collaborator

@kasperjo: Let's add some simple tests here. Current versions of the simulator do not contain a trading cost model. @kasperjo: Chat later today? 9am PST?

Sounds good! (Using the lock file should still work, right?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants